linux-kernel - Re: [PATCH v2] arm: rust: Enable Rust support for ARMv7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXEHpaOnFTDiLUZEUcq-SzwyXnRgbYokrAnrZc_0YOH31A@mail.gmail.com>
Date: Thu, 4 Jul 2024 10:41:53 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Christian Schrefl <chrisi.schrefl@...il.com>, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, rust-for-linux@...r.kernel.org, 
	Miguel Ojeda <ojeda@...nel.org>, Jamie Cunliffe <Jamie.Cunliffe@....com>, 
	Sven Van Asbroeck <thesven73@...il.com>, Geert Stappers <stappers@...ppers.nl>, Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH v2] arm: rust: Enable Rust support for ARMv7

On Thu, 4 Jul 2024 at 10:20, Alice Ryhl <aliceryhl@...gle.com> wrote:
>
> On Mon, Jun 17, 2024 at 6:04 PM Christian Schrefl
> <chrisi.schrefl@...il.com> wrote:
> > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > index 71afdd98ddf2..9cc10e32e8be 100644
> > --- a/arch/arm/Makefile
> > +++ b/arch/arm/Makefile
> > @@ -150,6 +150,7 @@ endif
> >  KBUILD_CPPFLAGS        +=$(cpp-y)
> >  KBUILD_CFLAGS  +=$(CFLAGS_ABI) $(CFLAGS_ISA) $(arch-y) $(tune-y) $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,)) -msoft-float -Uarm
> >  KBUILD_AFLAGS  +=$(CFLAGS_ABI) $(AFLAGS_ISA) -Wa,$(arch-y) $(tune-y) -include asm/unified.h -msoft-float
> > +KBUILD_RUSTFLAGS += --target=arm-unknown-linux-gnueabi
>
> On arm64 we use a target called aarch64-unknown-none. Should you also
> be using arm-unknown-none? Or maybe the arm64 target should be changed
> to aarch64-unknown-linux-gnueabi?
>

Neither. EABI is highly specific to 32-bit ARM, no point in trying to
align this between architectures.