linux-kernel - Re: [PATCH] drm/msm: Fix incorrect file name output in adreno_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <019146e8-25b3-474a-b433-c69d4fbe0ee0@linaro.org>
Date: Thu, 4 Jul 2024 12:47:28 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Aleksandr Mishin <amishin@...rgos.ru>,
 Jordan Crouse <jordan@...micpenguin.net>
Cc: Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Abhinav Kumar <quic_abhinavk@...cinc.com>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH] drm/msm: Fix incorrect file name output in
 adreno_request_fw()

On 04/07/2024 12:30, Aleksandr Mishin wrote:
> In adreno_request_fw() when debugging information is printed to the log
> after firmware load, an incorrect filename is printed. 'newname' is used
> instead of 'fwname', so prefix "qcom/" is being added to filename.
> Looks like "copy-paste" mistake.
> 
> Fix this mistake by replacing 'newname' with 'fwname'.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 9fe041f6fdfe ("drm/msm: Add msm_gem_get_and_pin_iova()")

Fixes tag is incorrect, LGTM otherwise.

> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> ---
>   drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index 074fb498706f..0bb7d66047f8 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -475,7 +475,7 @@ adreno_request_fw(struct adreno_gpu *adreno_gpu, const char *fwname)
>   		ret = request_firmware_direct(&fw, fwname, drm->dev);
>   		if (!ret) {
>   			DRM_DEV_INFO(drm->dev, "loaded %s from legacy location\n",
> -				newname);
> +				fwname);
>   			adreno_gpu->fwloc = FW_LOCATION_LEGACY;
>   			goto out;
>   		} else if (adreno_gpu->fwloc != FW_LOCATION_UNKNOWN) {

-- 
With best wishes
Dmitry