linux-kernel - Re: [PATCH net] wifi: rtw89: Fix array index mistake in rtw89_sta_info_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wmm1cwl1.fsf@kernel.org>
Date: Thu, 04 Jul 2024 12:53:14 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Ping-Ke Shih <pkshih@...ltek.com>,  <linux-wireless@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>,  <lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] wifi: rtw89: Fix array index mistake in
 rtw89_sta_info_get_iter()

Aleksandr Mishin <amishin@...rgos.ru> writes:

> In rtw89_sta_info_get_iter() 'status->he_gi' is compared to array size.
> But then 'rate->he_gi' is used as array index instead of 'status->he_gi'.
> This can lead to go beyond array boundaries in case of 'rate->he_gi' is
> not equal to 'status->he_gi' and is bigger than array size. Looks like
> "copy-paste" mistake.
>
> Fix this mistake by replacing 'rate->he_gi' with 'status->he_gi'.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: e3ec7017f6a2 ("rtw89: add Realtek 802.11ax driver")
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>

A reminder for maintainers: rtw89 patches go to Ping's rtw tree, not net
tree.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches