lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <113a83df-119b-4119-b720-61615713816b@axis.com>
Date: Thu, 4 Jul 2024 12:59:17 +0200
From: Kamil Horák (2N) <kamilh@...s.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/4] net: phy: bcm54811: Add LRE registers definitions


On 6/22/24 20:37, Andrew Lunn wrote:
> On Fri, Jun 21, 2024 at 01:26:31PM +0200, Kamil Horák (2N) wrote:
>> Add the definitions of LRE registers for Broadcom BCM5481x PHY
>>
>> Signed-off-by: Kamil Horák (2N) <kamilh@...s.com>
>> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
>> ---
>>   include/linux/brcmphy.h | 89 +++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 89 insertions(+)
>>
>> diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
>> index 1394ba302367..ae39c33e4086 100644
>> --- a/include/linux/brcmphy.h
>> +++ b/include/linux/brcmphy.h
>> @@ -270,6 +270,86 @@
>>   #define BCM5482_SSD_SGMII_SLAVE		0x15	/* SGMII Slave Register */
>>   #define BCM5482_SSD_SGMII_SLAVE_EN	0x0002	/* Slave mode enable */
>>   #define BCM5482_SSD_SGMII_SLAVE_AD	0x0001	/* Slave auto-detection */
>> +#define BCM5482_SSD_SGMII_SLAVE_AD	0x0001	/* Slave auto-detection */
> That looks odd. Is there something subtle i'm not seeing here?
>
> 	Andrew

Obviously an artifact from replaying the commits again and again... :-(

Fixed.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ