linux-kernel - Re: [PATCH] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c: fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZoYDtLXte9OvUC9e@google.com>
Date: Thu, 4 Jul 2024 02:06:44 +0000
From: Roman Gushchin <roman.gushchin@...ux.dev>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Shakeel Butt <shakeel.butt@...ux.dev>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Johannes Weiner <hannes@...xchg.org>,
	Michal Hocko <mhocko@...nel.org>,
	Muchun Song <muchun.song@...ux.dev>
Subject: Re: [PATCH] mm: memcg: move cgroup v1 oom handling code into
 memcontrol-v1.c: fixup

On Wed, Jul 03, 2024 at 06:52:50PM -0700, Andrew Morton wrote:
> On Thu,  4 Jul 2024 00:27:12 +0000 Roman Gushchin <roman.gushchin@...ux.dev> wrote:
> 
> > This is a small fixup for the commit
> > "mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c".
> > 
> > I forgot to actually move two functions mem_cgroup_node_nr_lru_pages()
> > and mem_cgroup_nr_lru_pages() into mm/memcontrol-v1.c, so that they remain
> > in mm/memcontrol.c and their commented out duplicated versions in
> > mm/memcontrol-v1.c.
> > 
> > Andrew, can you, please, squash it into the original commit?
> > 
> 
> Seems this wants to live behind "mm: memcg: move cgroup v1 interface
> files to memcontrol-v1.c" so that's where I placed it.

Right, this is the proper place for it.

Thank you!