linux-kernel - Re: [PATCH v2 02/12] PCI: brcmstb: Use "clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54dc90df-fc31-457d-a18d-b2070b055d60@web.de>
Date: Thu, 4 Jul 2024 13:40:22 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Jim Quinlan <james.quinlan@...adcom.com>, linux-pci@...r.kernel.org,
 bcm-kernel-feedback-list@...adcom.com, linux-arm-kernel@...ts.infradead.org,
 linux-rpi-kernel@...ts.infradead.org, Bjorn Helgaas <bhelgaas@...gle.com>,
 Cyril Brulebois <kibi@...ian.org>,
 Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
 Nicolas Saenz Julienne <nsaenz@...nel.org>,
 Stanimir Varbanov <svarbanov@...e.de>
Cc: Jim Quinlan <jim2101024@...il.com>, LKML <linux-kernel@...r.kernel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 02/12] PCI: brcmstb: Use "clk_out" error path label

> [-- Attachment #1: Type: text/plain, Size: 1685 bytes --]

Can improved adjustments be provided as regular diff data
(without an extra attachment)?


> Instead of invoking "clk_disable_unprepare(pcie->clk)" in
> a number of error paths, we can just use a "clk_out" label
> and goto the label after setting the return value.

* Please improve such a change description with imperative wordings.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94

* How do you think about to use a summary phrase like
  “Use more common error handling code in brcm_pcie_probe()”?


…
> +++ b/drivers/pci/controller/pcie-brcmstb.c
…
>  	ret = reset_control_reset(pcie->rescal);
> -	if (ret)
> +	if (ret) {
>  		dev_err(&pdev->dev, "failed to deassert 'rescal'\n");
> +		goto clk_out;
> +	}
>
>  	ret = brcm_phy_start(pcie);
…

Does this software update complete the exception handling?

Would you like to add any tags (like “Fixes” and “Cc”) accordingly?


…
> @@ -1676,6 +1677,9 @@ static int brcm_pcie_probe(struct platform_device *pdev)
>
>  	return 0;
>
> +clk_out:
> +	clk_disable_unprepare(pcie->clk);
> +	return ret;
>  fail:
…

I suggest to add a blank line before the second label.

Regards,
Markus