linux-kernel - Re: [PATCH v2] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4e9eddb-d5a8-4534-91eb-8dcdad593f5d@linux.alibaba.com>
Date: Thu, 4 Jul 2024 19:46:47 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Stanislav Jakubek <stano.jakubek@...il.com>,
 Bjorn Andersson <andersson@...nel.org>, baolin.wang7@...il.com,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>
Cc: linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: hwlock: sprd-hwspinlock: convert to YAML



On 2024/7/4 19:38, Stanislav Jakubek wrote:
> Convert the Spreadtrum hardware spinlock bindings to DT schema.
> 
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>

LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
> Changes in V2:
>    - fix double space in example
>    - switch to #address-cells = <1> and #size-cells = <1> in example
>    - add Conor's R-b
> 
>   .../bindings/hwlock/sprd,hwspinlock-r3p0.yaml | 50 +++++++++++++++++++
>   .../bindings/hwlock/sprd-hwspinlock.txt       | 23 ---------
>   2 files changed, 50 insertions(+), 23 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/hwlock/sprd,hwspinlock-r3p0.yaml
>   delete mode 100644 Documentation/devicetree/bindings/hwlock/sprd-hwspinlock.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwlock/sprd,hwspinlock-r3p0.yaml b/Documentation/devicetree/bindings/hwlock/sprd,hwspinlock-r3p0.yaml
> new file mode 100644
> index 000000000000..abe11df25761
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwlock/sprd,hwspinlock-r3p0.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwlock/sprd,hwspinlock-r3p0.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spreadtrum hardware spinlock
> +
> +maintainers:
> +  - Orson Zhai <orsonzhai@...il.com>
> +  - Baolin Wang <baolin.wang7@...il.com>
> +  - Chunyan Zhang <zhang.lyra@...il.com>
> +
> +properties:
> +  compatible:
> +    const: sprd,hwspinlock-r3p0
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: enable
> +
> +  '#hwlock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#hwlock-cells'
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/sprd,sc9860-clk.h>
> +
> +    hwlock@...00000 {
> +      compatible = "sprd,hwspinlock-r3p0";
> +      reg = <0x40500000 0x1000>;
> +      clocks = <&aon_gate CLK_SPLK_EB>;
> +      clock-names = "enable";
> +      #hwlock-cells = <1>;
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/hwlock/sprd-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/sprd-hwspinlock.txt
> deleted file mode 100644
> index 581db9d941ba..000000000000
> --- a/Documentation/devicetree/bindings/hwlock/sprd-hwspinlock.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -SPRD Hardware Spinlock Device Binding
> --------------------------------------
> -
> -Required properties :
> -- compatible : should be "sprd,hwspinlock-r3p0".
> -- reg : the register address of hwspinlock.
> -- #hwlock-cells : hwlock users only use the hwlock id to represent a specific
> -	hwlock, so the number of cells should be <1> here.
> -- clock-names : Must contain "enable".
> -- clocks : Must contain a phandle entry for the clock in clock-names, see the
> -	common clock bindings.
> -
> -Please look at the generic hwlock binding for usage information for consumers,
> -"Documentation/devicetree/bindings/hwlock/hwlock.txt"
> -
> -Example of hwlock provider:
> -	hwspinlock@...00000 {
> -		compatible  = "sprd,hwspinlock-r3p0";
> -		reg = <0 0x40500000 0 0x1000>;
> -		#hwlock-cells = <1>;
> -		clock-names = "enable";
> -		clocks = <&clk_aon_apb_gates0 22>;
> -	};