linux-kernel - Re: [PATCH 6/6] misc: sbrmi: Add support for new revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024070452-bunkbed-example-9dd3@gregkh>
Date: Thu, 4 Jul 2024 13:54:29 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Akshay Gupta <akshay.gupta@....com>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux@...ck-us.net, arnd@...db.de, naveenkrishna.chatradhi@....com
Subject: Re: [PATCH 6/6] misc: sbrmi: Add support for new revision

On Thu, Jul 04, 2024 at 11:16:24AM +0000, Akshay Gupta wrote:
> - RMI device supports v21 on Turin, which has increased register set.
>   Hence, requires 2byte for register addressing.
> 
> - Both Genoa and Turin processors are SP5 compatible, often CPUs are
>   interchanged on the base boards with BMC remaining the same.
>   Hence, we need to identify correct regmap configuration. A mechanism
>   was not defined to identify the RMI register address width.
> - The address width can only be determined if the socket is powered ON.
> - This patch also addresses CPUID and MCAMSR register read protocol,
>   the modification is due to the increase in register address size and
>   the modified thread input.
> 

When you have to list all of the different things you did in a single
change, that's a huge hint that it needs to be split up.

Remember, each patch can only do _one_ thing.

Would you want to review something that attempted to do all of this at
once?

thanks,

greg k-h