linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06e69b64b25fbbff338aac9e84c68ce9@manjaro.org>
Date: Thu, 04 Jul 2024 14:04:18 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Alex Bee <knaerzche@...il.com>
Cc: Heiko Stuebner <heiko@...ech.de>, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board

Hello Alex and Heiko,

On 2024-07-04 12:52, Alex Bee wrote:
> Am 03.07.24 um 23:05 schrieb Heiko Stuebner:
>> The Rock 5 ITX as the name suggests is made in the ITX form factor and
>> actually build in a form to be used in a regular case even providing
>> connectors for regular front-panel io.
>> 
>> It can be powered either bei 12V, ATX power-supply or PoE.
>> 
>> Notable peripherals are the 4 SATA ports, M.2 M-Key slot, M.2 E-key 
>> slot,
>> 2*2.5Gb pcie-connected ethernet nics.
>> 
>> As of yet unsupported display options consist of 2*hdmi, DP via 
>> type-c,
>> eDP + 2*DSI via pcb connectors.
>> 
>> USB ports are 4*USB3 + 2*USB2 on the back panel and 2-port front-panel
>> connector.
>> 
>> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
>> ---
>>   arch/arm64/boot/dts/rockchip/Makefile         |    1 +
>>   .../boot/dts/rockchip/rk3588-rock-5itx.dts    | 1188 
>> +++++++++++++++++
>>   2 files changed, 1189 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5itx.dts

[snip]

>> +&usb_host1_xhci {
>> +	dr_mode = "host";
>> +	#address-cells = <1>;
>> +	#size-cells = <0>;
>> +	status = "okay";
>> +
>> +	/* 2.0 hub on port 1 */
>> +	hub_2_0: hub@1 {
>> +		compatible = "usb5e3,610";
>> +		reg = <1>;
>> +		peer-hub = <&hub_3_0>;
>> +		vdd-supply = <&vcc5v0_usb12>;
> 
> Are you sure about this one? I couldn't find any schematics for this 
> board,
> but both the bindings for usb5e3,610 and the datasheet[0] are saying 
> this
> is the supply for the hub's internal logic which is typically ~3.3V. 
> It's
> definitely not a supply for the vbus.
> 
> [0] http://www.sunnyqi.com/upLoad/product/month_1308/GL852G.pdf

FYI, here's the board schematic:

- https://dl.radxa.com/rock5/5itx/radxa_rock_5_itx_X1100_schematic.pdf
- 
https://dl.radxa.com/rock5/5itx/v1110/radxa_rock_5itx_v1110_schematic.pdf

Perhaps it would be good to include these URLs in the v3 patch 
description.