linux-kernel - Re: [PATCH] drm/vkms: Remove event from vkms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdebd2b3-d1e3-4d01-b6da-ec369aa8b0b8@igalia.com>
Date: Thu, 4 Jul 2024 09:10:04 -0300
From: Maíra Canal <mcanal@...lia.com>
To: Lyude Paul <lyude@...hat.com>, dri-devel@...ts.freedesktop.org
Cc: Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
 Melissa Wen <melissa.srw@...il.com>,
 Haneen Mohammed <hamohammed.sa@...il.com>, Daniel Vetter <daniel@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/vkms: Remove event from vkms_output

On 7/3/24 13:04, Lyude Paul wrote:
> While working on rvkms, I noticed that there's no code that actually uses
> the drm_pending_vblank_event that's embedded in vkms_output. So, just drop
> the member from the struct.
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>

Reviewed-by: Maíra Canal <mcanal@...lia.com>

Feel free to apply it to drm-misc/drm-misc-next! Otherwise, I'll apply
it over the weekend.

Best Regards,
- Maíra

> ---
>   drivers/gpu/drm/vkms/vkms_drv.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h
> index 8f5710debb1eb..5e46ea5b96dcc 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.h
> +++ b/drivers/gpu/drm/vkms/vkms_drv.h
> @@ -103,7 +103,6 @@ struct vkms_output {
>   	struct drm_writeback_connector wb_connector;
>   	struct hrtimer vblank_hrtimer;
>   	ktime_t period_ns;
> -	struct drm_pending_vblank_event *event;
>   	/* ordered wq for composer_work */
>   	struct workqueue_struct *composer_workq;
>   	/* protects concurrent access to composer */