linux-kernel - Re: [PATCH] sched/fair: Optimize vlag entity placement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3f7c1ab-b949-4246-9691-8fc79cdb7001@arm.com>
Date: Thu, 4 Jul 2024 13:20:40 +0100
From: Metin Kaya <metin.kaya@....com>
To: Fernand Sieber <sieberf@...zon.com>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Juri Lelli <juri.lelli@...hat.com>,
 Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] sched/fair: Optimize vlag entity placement

On 04/07/2024 10:23 am, Fernand Sieber wrote:
> Optimize for common path when placing an entity with no lag.
> Since adjusting a zero lag is always going to produce a zero lag regardless
> of the local load, don't bother about calaculating the adjusting factor.
                                         calculating

> 
> Signed-off-by: Fernand Sieber <sieberf@...zon.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Juri Lelli <juri.lelli@...hat.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> ---
>   kernel/sched/fair.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 8a5b1ae0aa55..e78272c87274 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5190,7 +5190,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
>   	 *
>   	 * EEVDF: placement strategy #1 / #2
>   	 */
> -	if (sched_feat(PLACE_LAG) && cfs_rq->nr_running) {
> +	if (se->vlag && sched_feat(PLACE_LAG) && cfs_rq->nr_running) {
>   		struct sched_entity *curr = cfs_rq->curr;
>   		unsigned long load;
>   

Thanks,