linux-kernel - Re: [PATCH] macintosh/mac_hid: add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871q49jq4s.fsf@mail.lhotse>
Date: Thu, 04 Jul 2024 22:30:43 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Cc: Jeff Johnson <quic_jjohnson@...cinc.com>
Subject: Re: [PATCH] macintosh/mac_hid: add MODULE_DESCRIPTION()

Jeff Johnson <quic_jjohnson@...cinc.com> writes:
> Fix the make W=1 warning:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/macintosh/mac_hid.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  drivers/macintosh/mac_hid.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
> index 1ae3539beff5..eb7a173da071 100644
> --- a/drivers/macintosh/mac_hid.c
> +++ b/drivers/macintosh/mac_hid.c
> @@ -16,6 +16,7 @@
>  #include <linux/module.h>
>  #include <linux/slab.h>
>  
> +MODULE_DESCRIPTION("Macintosh mouse button 2+3 emulation");

I dropped the "Macintosh" from this, because AIUI the driver is not
actually mac specific, despite where it lives in the tree.

cheers