linux-kernel - Re: [PATCH 1/3] printk: Add match_devname_and_update_preferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024070446-shuffling-maimed-85eb@gregkh>
Date: Thu, 4 Jul 2024 14:57:07 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Petr Mladek <pmladek@...e.com>
Cc: Tony Lindgren <tony.lindgren@...ux.intel.com>,
	Jonathan Corbet <corbet@....net>, Jiri Slaby <jirislaby@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	linux-serial@...r.kernel.org, Dhruva Gole <d-gole@...com>,
	Sebastian Reichel <sre@...nel.org>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] printk: Add
 match_devname_and_update_preferred_console()

On Thu, Jul 04, 2024 at 01:44:03PM +0200, Petr Mladek wrote:
> On Wed 2024-07-03 13:06:08, Tony Lindgren wrote:
> > Let's add match_devname_and_update_preferred_console() for driver
> > subsystems to call during init when the console is ready, and it's
> > character device name is known. For now, we use it only for the serial
> > layer to allow console=DEVNAME:0.0 style hardware based addressing for
> > consoles.
> > 
> > The earlier attempt on doing this caused a regression with the kernel
> > command line console order as it added calling __add_preferred_console()
> > again later on during init. A better approach was suggested by Petr where
> > we add the deferred console to the console_cmdline[] and update it later
> > on when the console is ready.
> > 
> > Suggested-by: Petr Mladek <pmladek@...e.com>
> > Co-developed-by: Petr Mladek <pmladek@...e.com>
> > Signed-off-by: Tony Lindgren <tony.lindgren@...ux.intel.com>
> 
> Reviewed-by: Petr Mladek <pmladek@...e.com>

Thanks for the review, I'll take this through the tty tree now.

greg k-h