linux-kernel - RE: [PATCH 04/10] iio: adc: ad7091r8: Constify struct regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <DM4PR03MB693592DF53C9419D7BF3DB9696DE2@DM4PR03MB6935.namprd03.prod.outlook.com>
Date: Thu, 4 Jul 2024 13:04:21 +0000
From: "Schmitt, Marcelo" <Marcelo.Schmitt@...log.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
        "Tanislav, Cosmin"
	<Cosmin.Tanislav@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        Jonathan Cameron
	<jic23@...nel.org>,
        Dan Robertson <dan@...obertson.com>, "Sa, Nuno"
	<Nuno.Sa@...log.com>,
        Jagath Jog J <jagathjog1996@...il.com>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        "marcelo.schmitt1@...il.com"
	<marcelo.schmitt1@...il.com>
CC: "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 04/10] iio: adc: ad7091r8: Constify struct regmap_bus


> From: Javier Carrasco <javier.carrasco.cruz@...il.com> 
> Sent: Wednesday, July 3, 2024 6:05 PM
> To: Tanislav, Cosmin <Cosmin.Tanislav@...log.com>; Lars-Peter Clausen <lars@...afoo.de>; Hennerich, Michael <Michael.Hennerich@...log.com>; Jonathan Cameron <jic23@...nel.org>; Dan Robertson <dan@...obertson.com>; Schmitt, Marcelo <Marcelo.Schmitt@...log.com>; Sa, Nuno > <Nuno.Sa@...log.com>; Jagath Jog J <jagathjog1996@...il.com>; Linus Walleij <linus.walleij@...aro.org>
> Cc: linux-iio@...r.kernel.org; linux-kernel@...r.kernel.org; Javier Carrasco <javier.carrasco.cruz@...il.com>
> Subject: [PATCH 04/10] iio: adc: ad7091r8: Constify struct regmap_bus
>
> `ad7091r8_regmap_bus` is not modified and can be declared as const to move its data to a read-only section.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/iio/adc/ad7091r8.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Marcelo Schmitt <marcelo.schmitt@...log.com>

> diff --git a/drivers/iio/adc/ad7091r8.c b/drivers/iio/adc/ad7091r8.c index 700564305057..c9e014d6a77c 100644
> --- a/drivers/iio/adc/ad7091r8.c
> +++ b/drivers/iio/adc/ad7091r8.c
> @@ -159,7 +159,7 @@ static int ad7091r_regmap_bus_reg_write(void *context, unsigned int reg,
>  	return spi_write(spi, &st->tx_buf, 2);  }
>  
> -static struct regmap_bus ad7091r8_regmap_bus = {
> +static const struct regmap_bus ad7091r8_regmap_bus = {
>  	.reg_read = ad7091r_regmap_bus_reg_read,
>  	.reg_write = ad7091r_regmap_bus_reg_write,
>  	.reg_format_endian_default = REGMAP_ENDIAN_BIG,