linux-kernel - Re: [PATCH v2] dt-bindings: clock: sprd,sc9860-clk: convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0b3248d-ef2d-4583-98d0-6b4b28a75ef6@kernel.org>
Date: Thu, 4 Jul 2024 15:38:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stanislav Jakubek <stano.jakubek@...il.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Orson Zhai <orsonzhai@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Baolin Wang <baolin.wang7@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: clock: sprd,sc9860-clk: convert to YAML

On 04/07/2024 14:40, Stanislav Jakubek wrote:
> Convert the Spreadtrum SC9860 clock bindings to DT schema.
> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>

Thank you for your patch. There is something to discuss/improve.

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - sprd,sc9860-aonsecure-clk
> +              - sprd,sc9860-aon-prediv
> +              - sprd,sc9860-ap-clk
> +              - sprd,sc9860-cam-clk
> +              - sprd,sc9860-disp-clk
> +              - sprd,sc9860-gpu-clk
> +              - sprd,sc9860-vsp-clk
> +    then:
> +      required:
> +        - reg

  properties:
    sprd,syscon: false

> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - sprd,sc9860-agcp-gate
> +              - sprd,sc9860-aon-gate
> +              - sprd,sc9860-apahb-gate
> +              - sprd,sc9860-apapb-gate
> +              - sprd,sc9860-cam-gate
> +              - sprd,sc9860-disp-gate
> +              - sprd,sc9860-pll
> +              - sprd,sc9860-pmu-gate
> +              - sprd,sc9860-vsp-gate
> +    then:
> +      required:
> +        - sprd,syscon

  properties:
    reg: false

Best regards,
Krzysztof