linux-kernel - Re: Re: [PATCH -next v2] misc: pci_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240704140021.2363403-1-rick.wertenbroek@gmail.com>
Date: Thu,  4 Jul 2024 16:00:21 +0200
From: Rick Wertenbroek <rick.wertenbroek@...il.com>
To: gregkh@...uxfoundation.org
Cc: abaci@...ux.alibaba.com,
	arnd@...db.de,
	jiapeng.chong@...ux.alibaba.com,
	kishon@...nel.org,
	kw@...ux.com,
	linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org,
	manivannan.sadhasivam@...aro.org,
	Rick Wertenbroek <rick.wertenbroek@...il.com>
Subject: Re: Re: [PATCH -next v2] misc: pci_endpoint_test: Remove some unused functions

On Thu, Jul 04, 2024 at 02:58:10PM +0200, Greg KH wrote:
> On Thu, Jul 04, 2024 at 04:14:06PM +0900, Krzysztof Wilczyński wrote:
> > Hello,
> >
> > > These functions are defined in the pci_endpoint_test.c file, but not
> > > called elsewhere, so delete these unused functions.
> > >
> > > drivers/misc/pci_endpoint_test.c:144:19: warning: unused function 'pci_endpoint_test_bar_readl'.
> > > drivers/misc/pci_endpoint_test.c:150:20: warning: unused function 'pci_endpoint_test_bar_writel'.
> >
> > Have you see my question to the first version of this patch?
>
> Yeah, I don't understand this at all, how is this patch even building?
>
> What tree/branch is it made against?
>
> thanks,
>
> greg k-h

Hi,
I can confirm in linux-next tag next-20240703 the functions are indeed removed.
See commit 0ace3d3b70ed6a474d52fc44ee9b0b1f16ca3724
misc: pci_endpoint_test: Use memcpy_toio()/memcpy_fromio() for BAR tests

Regards,
Rick