linux-kernel - Re: [PATCH v2 4/4] rust: macros: Enable the rest of the tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2GU6M1F3QN4.31TYYGTCNHJ9F@gmail.com>
Date: Thu, 04 Jul 2024 09:49:37 -0500
From: "Ethan D. Twardy" <ethan.twardy@...il.com>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Wedson Almeida Filho" <wedsonaf@...il.com>,
 "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Benno Lossin"
 <benno.lossin@...ton.me>, "Andreas Hindborg" <a.hindborg@...sung.com>,
 "Martin Rodriguez Reboredo" <yakoyoku@...il.com>, "Trevor Gross"
 <tmgross@...ch.edu>, "Aswin Unnikrishnan" <aswinunni01@...il.com>, "open
 list:RUST" <rust-for-linux@...r.kernel.org>, "open list"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] rust: macros: Enable the rest of the tests

On Thu Jul 4, 2024 at 4:43 AM CDT, Alice Ryhl wrote:
> On Mon, Jul 1, 2024 at 1:28 PM Ethan D. Twardy <ethan.twardy@...il.com> wrote:
> >
> > Now that the rusttest target for the macros crate is compiled with the
> > kernel crate as a dependency, the rest of the rustdoc tests can be
> > enabled.
> >
> > Signed-off-by: Ethan D. Twardy <ethan.twardy@...il.com>
>
> I would drop the newline before `fn main()` here:
>
> > @@ -221,6 +248,8 @@ pub fn concat_idents(ts: TokenStream) -> TokenStream {
> >  ///         unsafe { bindings::destroy_info(self.raw_info) };
> >  ///     }
> >  /// }
> > +///
> > +/// # fn main() {}
> >  /// ```

So close! v3 incoming :). Thank you for your review!