linux-kernel - Re: [PATCH] dm-table:fix zone block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd05398-cffa-f4ca-2ac3-74433be2316c@redhat.com>
Date: Thu, 4 Jul 2024 17:29:18 +0200 (CEST)
From: Mikulas Patocka <mpatocka@...hat.com>
To: Li Dong <lidong@...o.com>
cc: Alasdair Kergon <agk@...hat.com>, Mike Snitzer <snitzer@...nel.org>, 
    "open list:DEVICE-MAPPER  (LVM)" <dm-devel@...ts.linux.dev>, 
    open list <linux-kernel@...r.kernel.org>, opensource.kernel@...o.com
Subject: Re: [PATCH] dm-table:fix zone block_device not aligned with
 zonesize



On Thu, 4 Jul 2024, Li Dong wrote:

> For zone block devices, device_area_is_invalid may return an incorrect 
> value.
> 
> Failure log:
> [   19.337657]: device-mapper: table: 254:56: len=836960256 not aligned to
> h/w zone size 3244032 of sde
> [   19.337665]: device-mapper: core: Cannot calculate initial queue limits
> [   19.337667]: device-mapper: ioctl: unable to set up device queue for 
> new table.
> 
> Actually, the device's zone length is aligned to the zonesize.
> 
> Fixes: 5dea271b6d87 ("dm table: pass correct dev area size to device_area_is_valid")
> Signed-off-by: Li Dong <lidong@...o.com>
> ---
>  drivers/md/dm-table.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index 33b7a1844ed4..0bddae0bee3c 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -257,7 +257,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>  	if (bdev_is_zoned(bdev)) {
>  		unsigned int zone_sectors = bdev_zone_sectors(bdev);
>  
> -		if (start & (zone_sectors - 1)) {
> +		if (start % zone_sectors) {
>  			DMERR("%s: start=%llu not aligned to h/w zone size %u of %pg",
>  			      dm_device_name(ti->table->md),
>  			      (unsigned long long)start,
> @@ -274,7 +274,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>  		 * devices do not end up with a smaller zone in the middle of
>  		 * the sector range.
>  		 */
> -		if (len & (zone_sectors - 1)) {
> +		if (len % zone_sectors) {
>  			DMERR("%s: len=%llu not aligned to h/w zone size %u of %pg",
>  			      dm_device_name(ti->table->md),
>  			      (unsigned long long)len,
> -- 
> 2.31.1.windows.1

Hi

This probably won't compile on 32-bit architectures because the operators 
for 64-bit divide and modulo don't work there.

Please, rework the patch using dm_sector_div64.

Mikulas