linux-kernel - Re: [PATCH] firmware: qcom: tzmem: blacklist more platforms for SHM Bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240705103820587-0700.eberman@hu-eberman-lv.qualcomm.com>
Date: Fri, 5 Jul 2024 10:40:41 -0700
From: Elliot Berman <quic_eberman@...cinc.com>
To: Neil Armstrong <neil.armstrong@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@...aro.org>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firmware: qcom: tzmem: blacklist more platforms for SHM
 Bridge

On Thu, Jul 04, 2024 at 06:36:23PM +0200, Neil Armstrong wrote:
> On 04/07/2024 18:03, Bjorn Andersson wrote:
> > On Thu, Jul 04, 2024 at 02:12:46PM GMT, Dmitry Baryshkov wrote:
> > > The SHM bridge makes the Qualcomm RB3 and SM8150-HDK reset while probing
> > > the RMTFS (in qcom_scm_assign_mem()). Blacklist the SHM Bridge on
> > > corresponding platforms using SoC-level compat string. If later it's
> > > found that the bad behaviour is limited just to the particular boards
> > > rather than SoC, the compat strings can be adjusted.
> > > 
> > > Reported-by: Neil Armstrong <neil.armstrong@...aro.org>
> > > Fixes: f86c61498a57 ("firmware: qcom: tzmem: enable SHM Bridge support")
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > > ---
> > >   drivers/firmware/qcom/qcom_tzmem.c | 2 ++
> > >   1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/firmware/qcom/qcom_tzmem.c b/drivers/firmware/qcom/qcom_tzmem.c
> > > index 5d526753183d..c715729f071c 100644
> > > --- a/drivers/firmware/qcom/qcom_tzmem.c
> > > +++ b/drivers/firmware/qcom/qcom_tzmem.c
> > > @@ -78,6 +78,8 @@ static bool qcom_tzmem_using_shm_bridge;
> > >   /* List of machines that are known to not support SHM bridge correctly. */
> > >   static const char *const qcom_tzmem_blacklist[] = {
> > >   	"qcom,sc8180x",
> > > +	"qcom,sdm845", /* reset in rmtfs memory assignment */
> > > +	"qcom,sm8150", /* reset in rmtfs memory assignment */
> > 
> > What confidence do we have in that this list is now complete?
> 
> AFAIK we don't but at least we're sure with this patch, it successfully boots on:
> - db410c
> - db820c
> - rb3
> - hdk8150
> - rb5
> - hdk8350
> - hdk8450
> - qrd8550
> - hdk8550
> - qrd8650
> - hdk8650
> 
> => https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/pipelines/91268
> 
> Without this change it crashes on rb3 & hdk8150:
> - https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/152722#L749
> - https://git.codelinaro.org/linaro/qcomlt/ci/staging/cdba-tester/-/jobs/152723#L838
> 
> Neil
> 
> > 
> > As Bartosz says, we booted RB3 successfully with an earlier version of
> > this series, what changed?
> > 

Is it literally same device tested? I wonder if different firmware
versions behave differently.

- Elliot