linux-kernel - [PROBLEM net-next] drivers/pnp/pnpbios/core.c:90:20: error: variable ‘value’ set but not used [-Werror=unused-but-set-variable]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9c3efa71-d517-497d-8c52-0b96d42806db@gmail.com>
Date: Sat, 6 Jul 2024 00:20:07 +0200
From: Mirsad Todorovac <mtodorovac69@...il.com>
To: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
 linux-acpi@...r.kernel.org
Subject: [PROBLEM net-next] drivers/pnp/pnpbios/core.c:90:20: error: variable ‘value’ set but not used [-Werror=unused-but-set-variable]

Hi, all!

This is the result of testing randconfig with KCONFIG_SEED=0xEE7AB52F in next-20240703 vanilla tree on
Ubuntu 22.04 LTS. GCC used is gcc (Ubuntu 12.3.0-1ubuntu1~22.04) 12.3.0.

The particular error is as follows:

drivers/pnp/pnpbios/core.c: In function ‘pnp_dock_event’:
drivers/pnp/pnpbios/core.c:90:20: error: variable ‘value’ set but not used [-Werror=unused-but-set-variable]
   90 |         int i = 0, value;
      |                    ^~~~~

   75 /*
   76  *
   77  * DOCKING FUNCTIONS
   78  *
   79  */
   80 
   81 static struct completion unload_sem;
   82 
   83 /*
   84  * (Much of this belongs in a shared routine somewhere)
   85  */
   86 static int pnp_dock_event(int dock, struct pnp_docking_station_info *info)
   87 {
   88         static char const sbin_pnpbios[] = "/sbin/pnpbios";
   89         char *argv[3], **envp, *buf, *scratch;
   90         int i = 0, value;
   91 
   92         if (!(envp = kcalloc(20, sizeof(char *), GFP_KERNEL)))
   93                 return -ENOMEM;
   94         if (!(buf = kzalloc(256, GFP_KERNEL))) {
   95                 kfree(envp);
   96                 return -ENOMEM;
   97         }
   98 
   99         /* FIXME: if there are actual users of this, it should be
  100          * integrated into the driver core and use the usual infrastructure
  101          * like sysfs and uevents
  102          */
  103         argv[0] = (char *)sbin_pnpbios;
  104         argv[1] = "dock";
  105         argv[2] = NULL;
  106 
  107         /* minimal command environment */
  108         envp[i++] = "HOME=/";
  109         envp[i++] = "PATH=/sbin:/bin:/usr/sbin:/usr/bin";
  110 
  111 #ifdef  DEBUG
  112         /* hint that policy agent should enter no-stdout debug mode */
  113         envp[i++] = "DEBUG=kernel";
  114 #endif
  115         /* extensible set of named bus-specific parameters,
  116          * supporting multiple driver selection algorithms.
  117          */
  118         scratch = buf;
  119 
  120         /* action:  add, remove */
  121         envp[i++] = scratch;
  122         scratch += sprintf(scratch, "ACTION=%s", dock ? "add" : "remove") + 1;
  123 
  124         /* Report the ident for the dock */
  125         envp[i++] = scratch;
  126         scratch += sprintf(scratch, "DOCK=%x/%x/%x",
  127                            info->location_id, info->serial, info->capabilities);
  128         envp[i] = NULL;
  129 
→ 130         value = call_usermodehelper(sbin_pnpbios, argv, envp, UMH_WAIT_EXEC);
  131         kfree(buf);
  132         kfree(envp);
  133         return 0;
  134 }

The error was apparently introduced by commit 1da177e4c3f4 (tag: v2.6.12-rc2).

Hope this helps.

Best regards,
Mirsad Todorovac

View attachment ".config" of type "text/plain" (134537 bytes)