linux-kernel - Re: [PATCH v4 2/7] btrfs: rst: don't print tree dump in case lookup fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbeec10c-bdee-4609-b796-db772fe1543c@gmx.com>
Date: Sat, 6 Jul 2024 08:50:59 +0930
From: Qu Wenruo <quwenruo.btrfs@....com>
To: Johannes Thumshirn <jth@...nel.org>, Chris Mason <clm@...com>,
 Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>
Cc: linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
 Johannes Thumshirn <johannes.thumshirn@....com>
Subject: Re: [PATCH v4 2/7] btrfs: rst: don't print tree dump in case lookup
 fails



在 2024/7/6 00:43, Johannes Thumshirn 写道:
> From: Johannes Thumshirn <johannes.thumshirn@....com>
>
> Don't print tree dump in case a raid-stripe-tree lookup fails.
>
> Dumping the stripe tree in case of a lookup failure was originally
> intended to be a debug feature, but it turned out to be a problem, in case
> of i.e. readahead.

But why readahead is going to cause problem?

IIRC the readahead is still based on file, in that case it still needs
to go through the data extents, then rst mapping.

Thus mind you explain more on the readahead problem?

Thanks,
Qu
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>
> ---
>   fs/btrfs/raid-stripe-tree.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/raid-stripe-tree.c b/fs/btrfs/raid-stripe-tree.c
> index 3b32e96c33fc..84746c8886be 100644
> --- a/fs/btrfs/raid-stripe-tree.c
> +++ b/fs/btrfs/raid-stripe-tree.c
> @@ -281,10 +281,8 @@ int btrfs_get_raid_extent_offset(struct btrfs_fs_info *fs_info,
>   out:
>   	if (ret > 0)
>   		ret = -ENOENT;
> -	if (ret && ret != -EIO && !stripe->is_scrub) {
> -		if (IS_ENABLED(CONFIG_BTRFS_DEBUG))
> -			btrfs_print_tree(leaf, 1);
> -		btrfs_err(fs_info,
> +	if (ret && ret != -EIO) {
> +		btrfs_debug(fs_info,
>   		"cannot find raid-stripe for logical [%llu, %llu] devid %llu, profile %s",
>   			  logical, logical + *length, stripe->dev->devid,
>   			  btrfs_bg_type_to_raid_name(map_type));
>