[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f3b86a0f-54ea-4a41-869e-643cbbad8192@chromium.org>
Date: Fri, 5 Jul 2024 14:27:53 +0900
From: Max Staudt <mstaudt@...omium.org>
To: Bingbu Cao <bingbu.cao@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Bingbu Cao <bingbu.cao@...el.com>, Tianshu Qiu <tian.shu.qiu@...el.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH v1 3/3] staging: media: ipu3: Stop streaming in inverse
order of starting
On 7/5/24 1:03 PM, Bingbu Cao wrote:
> I guess the real problem is the subdev s_stream cannot be called multiple
> times, please correct me if I am wrong as I have not touch IPU3 for long
> time. :)
>
> You can ignore my previous comment - 's_stream' is fine here.
Yes, indeed the multiple calls were what the newer V4L2 versions are
screaming about, and what made me write this patch...
> Just a nit, stop_stream and s_stream only happen after imgu_s_stream(), so I
> think they can be together and no need 'stop_streaming'. I think the mutex
> is mainly for imgu_s_stream, subdev stream on/off should work without it.
> It depends on you. :)
>
> It'll be better that others who is still working on IPU3 devices can review.
Okay, let's wait for their feedback then before I send a v2.
> Besides,
> Reviewed-by: Bingbu Cao <bingbu.cao@...el.com>
Appreciated! Let's do a v2, when other Intel folks have had a chance to
chime in.
Max
Powered by blists - more mailing lists