linux-kernel - Re: [PATCH v2 14/24] mfd: rohm-bd718x7: Constify struct regmap_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c487772e-08c6-4b30-af27-b32d6f5f176f@gmail.com>
Date: Fri, 5 Jul 2024 08:48:50 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Support Opensource <support.opensource@...semi.com>,
 Lee Jones <lee@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Xu Yilun <yilun.xu@...el.com>,
 Tom Rix <trix@...hat.com>, Marek Vasut <marek.vasut+renesas@...il.com>,
 Andy Shevchenko <andy@...nel.org>, Tony Lindgren <tony@...mide.com>,
 Tim Harvey <tharvey@...eworks.com>, Orson Zhai <orsonzhai@...il.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Chunyan Zhang <zhang.lyra@...il.com>
Cc: linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 14/24] mfd: rohm-bd718x7: Constify struct
 regmap_irq_chip

On 7/4/24 20:23, Javier Carrasco wrote:
> `bd718xx_irq_chip` is not modified and can be declared as const to
> move its data to a read-only section.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

> ---
>   drivers/mfd/rohm-bd718x7.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index 7755a4c073bf..25e494a93d48 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -60,7 +60,7 @@ static const struct regmap_irq bd718xx_irqs[] = {
>   	REGMAP_IRQ_REG(BD718XX_INT_STBY_REQ, 0, BD718XX_INT_STBY_REQ_MASK),
>   };
>   
> -static struct regmap_irq_chip bd718xx_irq_chip = {
> +static const struct regmap_irq_chip bd718xx_irq_chip = {
>   	.name = "bd718xx-irq",
>   	.irqs = bd718xx_irqs,
>   	.num_irqs = ARRAY_SIZE(bd718xx_irqs),
> 

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~