linux-kernel - Re: [PATCH v2 24/24] mfd: sprd-sc27xx-spi: Constify struct regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a46a766e-92f3-4dcf-b34f-cbeecc3b170b@linux.alibaba.com>
Date: Fri, 5 Jul 2024 09:11:01 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Support Opensource <support.opensource@...semi.com>,
 Lee Jones <lee@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Matti Vaittinen <mazziesaccount@...il.com>, Xu Yilun <yilun.xu@...el.com>,
 Tom Rix <trix@...hat.com>, Marek Vasut <marek.vasut+renesas@...il.com>,
 Andy Shevchenko <andy@...nel.org>, Tony Lindgren <tony@...mide.com>,
 Tim Harvey <tharvey@...eworks.com>, Orson Zhai <orsonzhai@...il.com>,
 Chunyan Zhang <zhang.lyra@...il.com>
Cc: linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 24/24] mfd: sprd-sc27xx-spi: Constify struct regmap_bus



On 2024/7/5 01:23, Javier Carrasco wrote:
> `sprd_pmic_regmap` is not modified and can be declared as const to
> move its data to a read-only section.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/mfd/sprd-sc27xx-spi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 81e517cdfb27..7186e2108108 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -135,7 +135,7 @@ static int sprd_pmic_spi_read(void *context,
>   	return 0;
>   }
>   
> -static struct regmap_bus sprd_pmic_regmap = {
> +static const struct regmap_bus sprd_pmic_regmap = {
>   	.write = sprd_pmic_spi_write,
>   	.read = sprd_pmic_spi_read,
>   	.reg_format_endian_default = REGMAP_ENDIAN_NATIVE,
>