linux-kernel - Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <F30D5471-B68C-442B-A34C-6EA0C8232006@xenosoft.de>
Date: Fri, 5 Jul 2024 08:59:10 +0200
From: Christian Zigotzky <chzigotzky@...osoft.de>
To: Marc Zyngier <maz@...nel.org>
Cc: Rob Herring <robh@...nel.org>, apatel@...tanamicro.com,
 DTML <devicetree@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
 mad skateman <madskateman@...il.com>, "R.T.Dickinson" <rtd2@...a.co.nz>,
 Matthew Leaman <matthew@...on.biz>,
 Darren Stevens <darren@...vens-zone.net>,
 Christian Zigotzky <info@...osoft.de>
Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

[snip]

My earlier request for valuable debug information still stands. But
while you're at it, can you please give the following hack a go?

   M.

--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -282,8 +282,10 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
               oldimap = imap;
             imap = of_irq_parse_imap_parent(oldimap, imaplen, out_irq);
-            if (!imap)
-                goto fail;
+            if (!imap) {
+                match = 0;
+                break;
+            }
               match &= of_device_is_available(out_irq->np);
             if (match)

This may not be the final workaround even if it solves your boot
problem, but will at least give us a hint at what is going wrong.

I have the fuzzy feeling that we may be able to lob this broken system
as part of the of_irq_imap_abusers[] array, which would solve things
pretty "neatly".

   M.

- - - -

We tested this patch yesterday and it solves the boot problem.

Thanks

- - - -

I am sorry our tester was wrong and has reported, that this kernel doesn’t boot.

Link: https://forum.hyperion-entertainment.com/viewtopic.php?p=58627#p58627

Sorry