linux-kernel - Re: [PATCH] hwmon: (ltc2991) re-order conditions to fix off by one bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <275932cb-9549-4cbe-9f7a-acb19378905e@roeck-us.net>
Date: Thu, 4 Jul 2024 18:15:05 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] hwmon: (ltc2991) re-order conditions to fix off by one
 bug

On Thu, Jul 04, 2024 at 10:18:59AM -0500, Dan Carpenter wrote:
> LTC2991_T_INT_CH_NR is 4.  The st->temp_en[] array has LTC2991_MAX_CHANNEL
> (4) elements.  Thus if "channel" is equal to LTC2991_T_INT_CH_NR then we
> have read one element beyond the end of the array.  Flip the conditions
> around so that we check if "channel" is valid before using it as an array
> index.
> 
> Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Applied.

Thanks,
Guenter