linux-kernel - Re: [PATCH V3 2/2] cpufreq: Add Loongson-3 CPUFreq driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H47OkbiA9awcCVwj4Jz-_o65rCSx++gU+OARhM+XSqLtQ@mail.gmail.com>
Date: Fri, 5 Jul 2024 16:28:07 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Huacai Chen <chenhuacai@...ngson.cn>, "Rafael J . Wysocki" <rafael@...nel.org>, loongarch@...ts.linux.dev, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Xuerui Wang <kernel@...0n.name>, Jiaxun Yang <jiaxun.yang@...goat.com>, 
	Binbin Zhou <zhoubinbin@...ngson.cn>
Subject: Re: [PATCH V3 2/2] cpufreq: Add Loongson-3 CPUFreq driver support

On Fri, Jul 5, 2024 at 4:17 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> On 05-07-24, 15:34, Huacai Chen wrote:
> > It seems except changing mutex_init to devm_mutex_init, all other
> > changes are line breaks? If so, I think additional tests are
> > unnecessary. :)
>
> Yeah, I just wanted to make sure the build passes and I have not
> introduced a stupid bug.
>
> > But now long lines (> 80 columns) are accepted by checkpatch.pl. Even
> > with --strict, only > 100 columns are warned.
> >
> > Especially for the change in loongson3_cpufreq_cpu_exit(), there is
> > only 82 columns and I think that line can keep as the original state.
> > And if possible, I also want the devm_kzalloc() line keep as original.
>
> Fair enough. I am still hung on 80 columns I believe, but I shouldn't
> be as the kernel has moved on :)
>
> New diff (Prototype of exit() callback has changed in my tree, so a
> change for that too).
>
> diff --git a/drivers/cpufreq/loongson3_cpufreq.c b/drivers/cpufreq/loongson3_cpufreq.c
> index a530e4a56b78..5f79b6de127c 100644
> --- a/drivers/cpufreq/loongson3_cpufreq.c
> +++ b/drivers/cpufreq/loongson3_cpufreq.c
> @@ -31,10 +31,10 @@ union smc_message {
>  };
>
>  /* Command return values */
> -#define CMD_OK                         0  /* No error */
> -#define CMD_ERROR                      1  /* Regular error */
> -#define CMD_NOCMD                      2  /* Command does not support */
> -#define CMD_INVAL                      3  /* Invalid Parameter */
> +#define CMD_OK                         0 /* No error */
> +#define CMD_ERROR                      1 /* Regular error */
> +#define CMD_NOCMD                      2 /* Command does not support */
> +#define CMD_INVAL                      3 /* Invalid Parameter */
>
>  /* Version commands */
>  /*
> @@ -230,7 +230,8 @@ static int loongson3_cpufreq_target(struct cpufreq_policy *policy, unsigned int
>  {
>         int ret;
>
> -       ret = do_service_request(cpu_data[policy->cpu].core, FREQ_INFO_TYPE_LEVEL, CMD_SET_FREQ_INFO, index, 0);
> +       ret = do_service_request(cpu_data[policy->cpu].core,
> +                                FREQ_INFO_TYPE_LEVEL, CMD_SET_FREQ_INFO, index, 0);
>
>         return (ret >= 0) ? 0 : ret;
>  }
> @@ -310,13 +311,11 @@ static int loongson3_cpufreq_cpu_init(struct cpufreq_policy *policy)
>         return 0;
>  }
>
> -static int loongson3_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> +static void loongson3_cpufreq_cpu_exit(struct cpufreq_policy *policy)
>  {
>         int cpu = policy->cpu;
>
>         loongson3_cpufreq_target(policy, per_cpu(freq_data, cpu)->def_freq_level);
> -
> -       return 0;
>  }
>
>  static int loongson3_cpufreq_cpu_online(struct cpufreq_policy *policy)
> @@ -348,13 +347,14 @@ static int loongson3_cpufreq_probe(struct platform_device *pdev)
>         int i, ret;
>
>         for (i = 0; i < MAX_PACKAGES; i++)
> -               mutex_init(&cpufreq_mutex[i]);
> +               devm_mutex_init(&pdev->dev, &cpufreq_mutex[i]);
>
>         ret = do_service_request(0, 0, CMD_GET_VERSION, 0, 0);
>         if (ret <= 0)
>                 return -EPERM;
>
> -       ret =  do_service_request(FEATURE_DVFS, 0, CMD_SET_FEATURE, FEATURE_DVFS_ENABLE | FEATURE_DVFS_BOOST, 0);
> +       ret = do_service_request(FEATURE_DVFS, 0, CMD_SET_FEATURE,
> +                                FEATURE_DVFS_ENABLE | FEATURE_DVFS_BOOST, 0);
>         if (ret < 0)
>                 return -EPERM;
>
>
> Applied the patch. You need to take 1/2 through the arch specific
> tree. Thanks.
OK, thank you very much.

Huacai
>
> --
> viresh
>