linux-kernel - Re: [PATCH RFC 3/3] arm64: dts: ti: grove: Add Grove Sunlight Sensor overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU55v0AR_jWojbWqdfWyzM-40Jvm5LnjE+hjdC5zNwRnA@mail.gmail.com>
Date: Fri, 5 Jul 2024 10:35:07 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andrew Davis <afd@...com>
Cc: Ayush Singh <ayush@...gleboard.org>, Nishanth Menon <nm@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Andrew Lunn <andrew@...n.ch>, Vaishnav M A <vaishnav@...gleboard.org>, 
	Derek Kiernan <derek.kiernan@....com>, Dragan Cvetic <dragan.cvetic@....com>, 
	Arnd Bergmann <arnd@...db.de>, Michael Walle <mwalle@...nel.org>, 
	Jason Kridner <jkridner@...gleboard.org>, Robert Nelson <robertcnelson@...gleboard.org>, 
	Robert Nelson <robertcnelson@...il.com>, Ayush Singh <ayushdevel1325@...il.com>, 
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 3/3] arm64: dts: ti: grove: Add Grove Sunlight Sensor overlay

Hi Andrew,

On Thu, Jul 4, 2024 at 6:56 PM Andrew Davis <afd@...com> wrote:
> The issue then is the overlay mechanism is not complete. We
> can add properties to nodes, and add nodes to nodes, and append
> properties to nodes, but cannot append values to existing properties,
> only replace them completely. This gap in the overlay system will
> prevent a general solution. So I've started to work on adding
> that property appending ability to the overlay system. I should
> have some patches posted against the upstream dtc/libfdt here
> in the next week or so.

This is not limited to overlays, but also true for plain dts.
We have /delete-node/ and /delete-property/, but lack /append-property/.

Hence we end up having to repeat all existing values when appending
to a property (e.g. see [1] appending to clocks from [2]).

[2] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/renesas/r8a77951-salvator-xs.dts#L39
[1] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/renesas/r8a77951.dtsi#L3334

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds