linux-kernel - Re: [PATCH] gpiolib: of: add polarity quirk for TSC2005

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY2S+G+u88P3x8emeq3-hEiRP89VbwM2TyRBd956Ro9BQ@mail.gmail.com>
Date: Fri, 5 Jul 2024 10:52:25 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Sebastian Reichel <sre@...nel.org>, Pali Rohár <pali@...nel.org>, 
	Pavel Machek <pavel@....cz>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpiolib: of: add polarity quirk for TSC2005

On Wed, Jul 3, 2024 at 8:26 PM Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:


> DTS for Nokia N900 incorrectly specifies "active high" polarity for
> the reset line, while the chip documentation actually specifies it as
> "active low".  In the past the driver fudged gpiod API and inverted
> the logic internally, but it was changed in d0d89493bff8.
>
> Fixes: d0d89493bff8 ("Input: tsc2004/5 - switch to using generic device properties")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

> OTOH if this was indeed broken, then it was broken for ~7 years
> (d0d89493bff8 went in 4.11-rc1), so maybe the best way is not to worry
> about compatibility with old DTS, update
> arch/arm/boot/dts/ti/omap/omap3-n900.dts in the tree and call it a day.

I think anybody using the n900 wll be updating DTS and kernel in tandem
so yeah. But I think it's nice that we do both since you anyway made
the patch, it doesn't hurt.

Yours,
Linus Walleij