linux-kernel - RE: [PATCH 2/5] dt-bindings: clock: add clock binding definitions for Exynos Auto v920

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01c601daceba$e5d32570$b1797050$@samsung.com>
Date: Fri, 5 Jul 2024 18:08:27 +0900
From: "sunyeal.hong" <sunyeal.hong@...sung.com>
To: "'Krzysztof Kozlowski'" <krzk@...nel.org>, "'Sylwester Nawrocki'"
	<s.nawrocki@...sung.com>, "'Chanwoo Choi'" <cw00.choi@...sung.com>, "'Alim
 Akhtar'" <alim.akhtar@...sung.com>, "'Michael Turquette'"
	<mturquette@...libre.com>, "'Stephen Boyd'" <sboyd@...nel.org>
Cc: <linux-samsung-soc@...r.kernel.org>, <linux-clk@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/5] dt-bindings: clock: add clock binding definitions
 for Exynos Auto v920

Hello Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Friday, July 5, 2024 5:52 PM
> To: sunyeal.hong <sunyeal.hong@...sung.com>; 'Sylwester Nawrocki'
> <s.nawrocki@...sung.com>; 'Chanwoo Choi' <cw00.choi@...sung.com>; 'Alim
> Akhtar' <alim.akhtar@...sung.com>; 'Michael Turquette'
> <mturquette@...libre.com>; 'Stephen Boyd' <sboyd@...nel.org>
> Cc: linux-samsung-soc@...r.kernel.org; linux-clk@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/5] dt-bindings: clock: add clock binding definitions
> for Exynos Auto v920
> 
> On 05/07/2024 10:03, sunyeal.hong wrote:
> >
> >> <form letter>
> >> Please use scripts/get_maintainers.pl to get a list of necessary
> >> people and lists to CC. It might happen, that command when run on an
> >> older kernel, gives you outdated entries. Therefore please be sure
> >> you base your patches on recent Linux kernel.
> >>
> >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> >> people, so fix your workflow. Tools might also fail if you work on
> >> some ancient tree (don't, instead use mainline) or work on fork of
> >> kernel (don't, instead use mainline). Just use b4 and everything
> >> should be fine, although remember about `b4 prep --auto-to-cc` if you
> >> added new patches to the patchset.
> >>
> >> You missed at least devicetree list (maybe more), so this won't be
> >> tested by automated tooling. Performing review on untested code might
> >> be a waste of time.
> >>
> >> Please kindly resend and include all necessary To/Cc entries.
> >> </form letter>
> >>
> >> Best regards,
> >> Krzysztof
> >
> > The mail list was created using get_maintainer.pl. If there is any
> problem, please let me know.
> >
> > ./scripts/get_maintainer.pl -f drivers/clk/samsung/
> 
> That's not how you run the command. You ALWAYS (unless you are Linus) run
> it on the patches. ALWAYS. See submitting patches or numerous
> presentations how to contribute upstream.
> 
> Read my form letter accurately, e.g. switch to b4.
> 
> Best regards,
> Krzysztof

Thank you for your quick and kind response.
I checked the difference in the mail list through "./scripts/get_maintainer.pl *.patch" and will reflect this.

Could you please answer additional questions I asked?
"Is your request to combine PATCH 0 and 1 correct? If correct, I will update it as requested."

The reason I'm asking this is that if you check checkpatch.pl, it says to classify patches as follows.
"DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst"
PATCH0: Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml
PATCH1: include/dt-bindings/clock/samsung,exynosautov920.h

Thanks,
Sunyeal Hong