linux-kernel - Re: [PATCH v7 1/2] mm: store zero pages to be swapped out in a bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d56d422-8d12-4ba7-9aec-704f08ecf07d@gmail.com>
Date: Fri, 5 Jul 2024 10:41:36 +0100
From: Usama Arif <usamaarif642@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Johannes Weiner <hannes@...xchg.org>, shakeel.butt@...ux.dev,
 david@...hat.com, ying.huang@...el.com, hughd@...gle.com,
 willy@...radead.org, yosryahmed@...gle.com, nphamcs@...il.com,
 chengming.zhou@...ux.dev, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 kernel-team@...a.com, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v7 1/2] mm: store zero pages to be swapped out in a bitmap



On 05/07/2024 02:22, Andrew Morton wrote:
> On Mon, 1 Jul 2024 20:15:46 +0300 Usama Arif <usamaarif642@...il.com> wrote:
> 
>> Changes from v7 (Johannes):
>> - Give overview and explain how locking works in zeromap in comments
>> - Add comment for why last word is checked first when checking if
>>   folio is zero-filled
>> - Merge is_folio_zero_filled and is_folio_page_zero_filled into
>>   1 function.
>> - Use folio_zero_range to fill a folio with zero at readtime.
>> - Put swap_zeromap_folio_clear in an else branch (even if checkpatch
>>   gives warning) and add comment to make it explicitly clear that it
>>   needs to happen if folio is not zero filled.
>> - add missing kvfree for zeromap incase swapon fails.
> 
> I queued the below as a delta against what was in mm-unstable.
> 
> Can we please get this nailed down?  

Thanks, yes its finished. There won't be anymore changes on this anymore.