linux-kernel - Re: [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240705094418.GAZofAcvelmnRzbkoG@fat_crate.local>
Date: Fri, 5 Jul 2024 11:44:18 +0200
From: Borislav Petkov <bp@...en8.de>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Andrew Cooper <andrew.cooper3@...rix.com>, dave.hansen@...el.com,
	xin@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	mingo@...hat.com, dave.hansen@...ux.intel.com, x86@...nel.org,
	peterz@...radead.org, nik.borisov@...e.com,
	houwenlong.hwl@...group.com
Subject: Re: [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns()

On Thu, Jul 04, 2024 at 07:45:00PM -0700, H. Peter Anvin wrote:
> Except that that would be more cleanly spelled wrmsrns()... let's just
> abstract the whole thing away and let the user use wrmsrns() whenever
> serialization is not necessary.

Just don't make it more complex and unreadable than it has to be.

cpu_feature_enabled() already is patching things for optimal perf so even if
PeterZ prefers the alternative, I say it is ugly and, more importantly,
unnecessary.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette