linux-kernel - Re: [PATCH 1/1] dt-bindings: ata: ahci-fsl-qoriq: add fsl,ls1046a-ahci and fsl,ls1012a-ahci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cce2627f-c02f-4699-81a2-3cd9a1f2d74b@kernel.org>
Date: Fri, 5 Jul 2024 09:20:52 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Frank Li <Frank.li@....com>, Krzysztof Kozlowski <krzk@...nel.org>
Cc: Niklas Cassel <cassel@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>,
 "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
 <linux-ide@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: ata: ahci-fsl-qoriq: add
 fsl,ls1046a-ahci and fsl,ls1012a-ahci

On 7/3/24 05:45, Frank Li wrote:
> On Wed, Jun 26, 2024 at 10:17:55AM +0200, Krzysztof Kozlowski wrote:
>> On 25/06/2024 22:57, Frank Li wrote:
>>> Add compatible string 'fsl,ls1046a-ahci' and 'fsl,ls1012a-ahci' compatible
>>> string. Allow 'fsl,ls1012a-ahci' fallback to 'fsl,ls1043a-ahci'.
>>>
>>> ls1046a ahci ecc disable bit is difference with other chips.
>>>
>>> Signed-off-by: Frank Li <Frank.Li@....com>
>>> ---
>>>  .../devicetree/bindings/ata/fsl,ahci.yaml     | 19 ++++++++++++-------
>>>  1 file changed, 12 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
>>> index 162b3bb5427ed..a244bc603549d 100644
>>> --- a/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
>>> +++ b/Documentation/devicetree/bindings/ata/fsl,ahci.yaml
>>> @@ -11,13 +11,18 @@ maintainers:
>>>  
>>>  properties:
>>>    compatible:
>>> -    enum:
>>> -      - fsl,ls1021a-ahci
>>> -      - fsl,ls1043a-ahci
>>> -      - fsl,ls1028a-ahci
>>> -      - fsl,ls1088a-ahci
>>> -      - fsl,ls2080a-ahci
>>> -      - fsl,lx2160a-ahci
>>> +    oneOf:
>>> +      - items:
>>> +          - const: fsl,ls1012a-ahci
>>> +          - const: fsl,ls1043a-ahci
>>> +      - enum:
>>> +          - fsl,ls1021a-ahci
>>> +          - fsl,ls1043a-ahci
>>> +          - fsl,ls1046a-ahci
>>
>> Where is the driver change for this?
>>
>> Your commit does not explain why you are doing it and without driver
>> change adding new support it is not obvious. This probably applies to
>> all your patches.
> 
> I think I missed ls1012a and ls1021a.  Commit message is wrong. This is
> for legancy platorm. 
> 
> Basic try to eliminate the CHECK_DTBS warning. ls1012a use
> 
> "fsl,ls1012a-ahci", "fsl,ls1043a-ahci". There are two methods, 
> 1. change binding doc to allow "fsl,ls1012a-ahci", "fsl,ls1043a-ahci"

But then shouldn't you also change the drivers/ata/ahci_qoriq.c to add ls1012a
as a compatible ?

> 2. remove "fsl,ls1012a-ahci".

I am not sure if that is acceptable since there is one device tree using it out
there already.

I am no DT expert, but I think (1) with the driver change is the right approach.
Krzysztof ?

-- 
Damien Le Moal
Western Digital Research