[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <D2HIQELPOBJD.1HJZS16QJSSZJ@bootlin.com>
Date: Fri, 05 Jul 2024 12:03:55 +0200
From: Théo Lebrun <theo.lebrun@...tlin.com>
To: "kernel test robot" <lkp@...el.com>, "Michael Turquette"
<mturquette@...libre.com>, "Stephen Boyd" <sboyd@...nel.org>, "Rob Herring"
<robh@...nel.org>, "Krzysztof Kozlowski" <krzk@...nel.org>, "Conor Dooley"
<conor+dt@...nel.org>
Cc: <llvm@...ts.linux.dev>, <oe-kbuild-all@...ts.linux.dev>,
<linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, "Vladimir Kondratiev"
<vladimir.kondratiev@...ileye.com>, Grégory Clement
<gregory.clement@...tlin.com>, "Thomas Petazzoni"
<thomas.petazzoni@...tlin.com>, "Tawfik Bayouk"
<tawfik.bayouk@...ileye.com>
Subject: Re: [PATCH v2 4/4] clk: eyeq: add driver
Hello,
*Grasp*, I forgot addressing this topic.
On Fri Jul 5, 2024 at 3:50 AM CEST, kernel test robot wrote:
> kernel test robot noticed the following build errors:
[...]
> All errors (new ones prefixed by >>):
>
> In file included from drivers/clk/clk-eyeq.c:30:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:548:31: warning: performing pointer
> arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 548 | val = __raw_readb(PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
[...]
Ignoring all the warnings relative to <linux/io.h> as they appear on all
objects using this config, nothing specific to clk-eyeq.
> >> drivers/clk/clk-eyeq.c:264:9: error: call to undeclared function
> >> 'readq'; ISO C99 and later do not support implicit function
> >> declarations [-Wimplicit-function-declaration]
> 264 | val = readq(priv->base + pll->reg64);
> | ^
Options are:
- #include <linux/io-64-nonatomic-lo-hi.h> or
<linux/io-64-nonatomic-hi-lo.h> or
- in Kconfig, add "depends on 64BIT # for readq()"
I'm leaning towards the Kconfig option. Build testing this driver on
32bit platforms makes no sense, this is a SoC clk platform driver used
on 64bit SoCs. Including a compat layer is a more complex solution.
I'll wait a bit before sending next revision.
You can ping if you want it straight away of course.
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists