linux-kernel - Re: [PATCH v4 1/8] iio: add read scale and offset services to iio backend framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1de64478918e495ccdcbcb5ad5bae0e48d45808.camel@gmail.com>
Date: Fri, 05 Jul 2024 12:18:16 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Olivier Moysan <olivier.moysan@...s.st.com>,
 fabrice.gasnier@...s.st.com,  Nuno Sa <nuno.sa@...log.com>, Jonathan
 Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/8] iio: add read scale and offset services to iio
 backend framework

On Thu, 2024-07-04 at 17:53 +0200, Olivier Moysan wrote:
> Add iio_backend_read_scale() and iio_backend_read_offset() services
> to read channel scale and offset from an IIO backbend device.
> 
> Also add a read_raw callback which replicates the read_raw callback of
> the IIO framework, and is intended to request miscellaneous channel
> attributes from the backend device.
> Both scale and offset helpers use this callback.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
> Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> ---
>  drivers/iio/industrialio-backend.c | 34 ++++++++++++++++++++++++++++++
>  include/linux/iio/backend.h        |  9 +++++++-
>  2 files changed, 42 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/industrialio-backend.c b/drivers/iio/industrialio-
> backend.c
> index efe05be284b6..4e0ff6e6e9d4 100644
> --- a/drivers/iio/industrialio-backend.c
> +++ b/drivers/iio/industrialio-backend.c
> @@ -357,6 +357,40 @@ int devm_iio_backend_request_buffer(struct device *dev,
>  }
>  EXPORT_SYMBOL_NS_GPL(devm_iio_backend_request_buffer, IIO_BACKEND);
>  
> +/**
> + * iio_backend_read_scale - Request channel scale from the IIO backend.
> + * @back:	Backend device
> + * @chan:	IIO channel reference
> + * @scale:	returned scale value
> + *
> + * RETURNS:
> + * 0 on success, negative error number on failure.
> + */
> +int iio_backend_read_scale(struct iio_backend *back,
> +			   struct iio_chan_spec const *chan, int *scale)
> +{
> +	return iio_backend_op_call(back, read_raw, chan, scale, NULL,
> +				   IIO_CHAN_INFO_SCALE);
> +}
> +EXPORT_SYMBOL_NS_GPL(iio_backend_read_scale, IIO_BACKEND);
> +
> +/**
> + * iio_backend_read_offset - Request channel offset from the IIO backend.
> + * @back:	Backend device
> + * @chan:	IIO channel reference
> + * @offset:	returned offset value
> + *
> + * RETURNS:
> + * 0 on success, negative error number on failure.
> + */
> +int iio_backend_read_offset(struct iio_backend *back,
> +			    struct iio_chan_spec const *chan, int *offset)
> +{
> +	return iio_backend_op_call(back, read_raw, chan, offset, NULL,
> +				   IIO_CHAN_INFO_OFFSET);
> +}
> +EXPORT_SYMBOL_NS_GPL(iio_backend_read_offset, IIO_BACKEND);
> +

Hi Olivier,

Not exactly what I had in mind :). My thinking was to have:

int iio_backend_read_raw(struct iio_backend *back,
			 struct iio_chan_spec const *chan, int *val, int *val2,
                         long mask)
{
	return iio_backend_op_call(back, read_raw, chan, val, val2, mask);
}
EXPORT_SYMBOL_NS_GPL(iio_backend_read_raw, IIO_BACKEND);

Then, on backend.h

static inline int iio_backend_read_scale(struct iio_backend *back, struct
iio_chan_spec const *chan, int *val, int val2)
{
	return iio_backend_read_raw(..., IIO_CHAN_INFO_SCALE);
}

Advantage is that we only need to export one symbol from the framework. But the most
important piece I don't really agree in the patch is assuming NULL for val2 (even
more in scale where often we use both vals). So I think it already makes sense to
expose the API with two int's even if you don't need them for your usecase.

- Nuno Sá