linux-kernel - Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA8EJpqmawrbXyhQ+5SrX+=F5LUuyLNnOb21SPzbg=3vbnDg7g@mail.gmail.com>
Date: Fri, 5 Jul 2024 13:37:07 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: neil.armstrong@...aro.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

On Fri, 5 Jul 2024 at 13:04, Neil Armstrong <neil.armstrong@...aro.org> wrote:
>
> On 05/07/2024 11:59, Krzysztof Kozlowski wrote:
> > On 04/06/2024 15:18, Krzysztof Kozlowski wrote:
> >> On 27/05/2024 16:47, Alain Volmat wrote:
> >>> Hi Krzysztof,
> >>>
> >>> thanks for your patch, sorry for the delay.
> >>>
> >>> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
> >>>> Core in platform_driver_register() already sets the .owner, so driver
> >>>> does not need to.  Whatever is set here will be anyway overwritten by
> >>>> main driver calling platform_driver_register().
> >>>>
> >>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >>>> ---
> >>>>
> >>>> I forgot two drivers.
> >>>>   drivers/gpu/drm/sti/sti_hdmi.c | 1 -
> >>>>   1 file changed, 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> >>>> index 500936d5743c..b0d84440a87b 100644
> >>>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> >>>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> >>>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
> >>>>   struct platform_driver sti_hdmi_driver = {
> >>>>    .driver = {
> >>>>            .name = "sti-hdmi",
> >>>> -          .owner = THIS_MODULE,
> >>>>            .of_match_table = hdmi_of_match,
> >>>>    },
> >>>>    .probe = sti_hdmi_probe,
> >>>> --
> >>>> 2.34.1
> >>>>
> >>>
> >>> Acked-by: Alain Volmat <alain.volmat@...s.st.com>
> >>
> >> What does this ack mean? You are the maintainer, so what is supposed to
> >> happen now? If maintainer does not take patches, then the DRM STI looks
> >> orphaned.
> >
> > +Cc Neil, Dmitry,
> >
> > I pinged and pinged and wanted some sort of clarification here but one
> > month passed and nothing was clarified.
> >
> > I could be understanding the DRM process wrong, but if no one picks up
> > trivial cleanups for 1.5 months, then to me subsystem is orphaned. I
> > will send respective MAINTAINERS update.
>
> Let's do that, if Alain doesn't take his own patches that were reviewed
> then it should either be orphaned  or moved to drm-misc.

But it already a part of drm-misc as far as I can see:

DRM DRIVERS FOR STI
M:      Alain Volmat <alain.volmat@...s.st.com>
L:      dri-devel@...ts.freedesktop.org
S:      Maintained
T:      git https://gitlab.freedesktop.org/drm/misc/kernel.git
F:      Documentation/devicetree/bindings/display/st,stih4xx.txt
F:      drivers/gpu/drm/sti

-- 
With best wishes
Dmitry