linux-kernel - Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240705-bustard-of-unreal-sorcery-bfc9ba@houat>
Date: Fri, 5 Jul 2024 13:14:30 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	Alain Volmat <alain.volmat@...s.st.com>
Subject: Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

+Alain

On Tue, Jun 04, 2024 at 03:18:55PM GMT, Krzysztof Kozlowski wrote:
> On 27/05/2024 16:47, Alain Volmat wrote:
> > Hi Krzysztof,
> > 
> > thanks for your patch, sorry for the delay.
> > 
> > On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
> >> Core in platform_driver_register() already sets the .owner, so driver
> >> does not need to.  Whatever is set here will be anyway overwritten by
> >> main driver calling platform_driver_register().
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> ---
> >>
> >> I forgot two drivers.
> >>  drivers/gpu/drm/sti/sti_hdmi.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> >> index 500936d5743c..b0d84440a87b 100644
> >> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> >> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> >> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
> >>  struct platform_driver sti_hdmi_driver = {
> >>  	.driver = {
> >>  		.name = "sti-hdmi",
> >> -		.owner = THIS_MODULE,
> >>  		.of_match_table = hdmi_of_match,
> >>  	},
> >>  	.probe = sti_hdmi_probe,
> >> -- 
> >> 2.34.1
> >>
> > 
> > Acked-by: Alain Volmat <alain.volmat@...s.st.com>
> 
> What does this ack mean? You are the maintainer, so what is supposed to
> happen now? If maintainer does not take patches, then the DRM STI looks
> orphaned.

The expectation would have been that Alain would have applied these
patches. That being said, your reply here dropped him from the
recipients list, so it's not surprising you didn't get any answer.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)