linux-kernel - Re: [PATCH v3 1/2] mm: add per-order mTHP split counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240705113119.82210-1-ioworker0@gmail.com>
Date: Fri,  5 Jul 2024 19:31:19 +0800
From: Lance Yang <ioworker0@...il.com>
To: akpm@...ux-foundation.org
Cc: ioworker0@...il.com,
	21cnbao@...il.com,
	baolin.wang@...ux.alibaba.com,
	david@...hat.com,
	dj456119@...il.com,
	libang.li@...group.com,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	mingzhe.yang@...com,
	ryan.roberts@....com,
	shy828301@...il.com,
	ziy@...dia.com
Subject: Re: [PATCH v3 1/2] mm: add per-order mTHP split counters

Hi Andrew,

Could you please fold the following changes into this patch?

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 993f0dd2a1ed..f8b5cbd4dd71 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3266,7 +3266,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
 		i_mmap_unlock_read(mapping);
 out:
 	xas_destroy(&xas);
-	if (order >= HPAGE_PMD_ORDER)
+	if (order == HPAGE_PMD_ORDER)
 		count_vm_event(!ret ? THP_SPLIT_PAGE : THP_SPLIT_PAGE_FAILED);
 	count_mthp_stat(order, !ret ? MTHP_STAT_SPLIT : MTHP_STAT_SPLIT_FAILED);
 	return ret;

Thanks,
Lance