linux-kernel - Re: [PATCH 6/6] iio: adc: ad5755: drop redundant devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2c14cfbe8aecb3d87ab7bb8d00a5965742433fb.camel@gmail.com>
Date: Fri, 05 Jul 2024 13:47:25 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Dan Robertson
 <dan@...obertson.com>, Jonathan Cameron <jic23@...nel.org>, Lars-Peter
 Clausen <lars@...afoo.de>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>,  Claudiu Beznea
 <claudiu.beznea@...on.dev>, Oleksij Rempel <o.rempel@...gutronix.de>,
 kernel@...gutronix.de
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 6/6] iio: adc: ad5755: drop redundant devm_kfree()

On Fri, 2024-07-05 at 12:40 +0200, Krzysztof Kozlowski wrote:
> The driver calls ad5755_parse_fw() only from probe() function, so
> devm_kfree() during error path is not necessary and only makes code
> weirder.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>