linux-kernel - Re: [PATCH 2/2] arm64: dts: armada-3720: align LED node name with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xtkj95m.fsf@BLaptop.bootlin.com>
Date: Fri, 05 Jul 2024 14:49:41 +0200
From: Gregory CLEMENT <gregory.clement@...tlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Andrew Lunn
 <andrew@...n.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH 2/2] arm64: dts: armada-3720: align LED node name with
 bindings

Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> writes:

> Bindings expect the LED node names to follow certain pattern, see
> dtbs_check warnings:
>
>   armada-3720-gl-mv1000.dtb: leds: 'power', 'vpn', 'wan' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Applied on mvebu/dt64

Thanks,

Gregory
> ---
>  arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> index 07c14bf04b83..56930f2ce481 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
> @@ -57,17 +57,17 @@ switch {
>  	leds {
>  		compatible = "gpio-leds";
>  
> -		vpn {
> +		led-vpn {
>  			label = "green:vpn";
>  			gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
>  		};
>  
> -		wan {
> +		led-wan {
>  			label = "green:wan";
>  			gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
>  		};
>  
> -		led_power: power {
> +		led_power: led-power {
>  			label = "green:power";
>  			gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
>  			default-state = "on";
> -- 
> 2.43.0