[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <19a4a521-2e68-402d-83d0-618c299f2c10@suswa.mountain>
Date: Fri, 5 Jul 2024 16:25:14 +0200
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ágatha Isabelle Chris Moreira Guedes <code@...tha.dev>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Luis Chamberlain <mcgrof@...nel.org>, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org,
Uwe Kleine-König <u.kleine-koenig@...libre.com>,
patch-reply@...tha.dev
Subject: Re: [PATCH v2] init: staging: Fix missing warning/taint on builtin
code
On Thu, Jul 04, 2024 at 09:20:49PM -0300, Ágatha Isabelle Chris Moreira Guedes wrote:
> +#ifdef CONFIG_STAGING
> +/**
> + * staging_init_taint() - We need to taint the kernel whenever staging code
> + * is initialized (from built-in drivers) or loaded (as modules) and issue
> + * a warning the first time it happens.
> + */
> +void staging_taint(const char *code_id, bool module)
> +{
> + char *code_type = module ? "module" : "builtin driver";
> +
> + pr_warn("%s %s: The kernel contains code from staging directory"
> + ", the quality is unknown, you have been warned.\n",
I wasn't going to say anything but since you're resending anyway,
please, don't break the line like this so it starts with a comma. The
comma can go on the line before. But if it couldn't then we would move
the whole word "directory," to the next line.
regards,
dan carpenter
Powered by blists - more mailing lists