linux-kernel - Re: [PATCH v2 10/12] PCI: brcmstb: Check return value of all reset_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+-6iNz5rsb0T+rYKJ91q-M4=QcfO6VtPnSp_vMokWpx1FJoRg@mail.gmail.com>
Date: Fri, 5 Jul 2024 10:28:35 -0400
From: Jim Quinlan <james.quinlan@...adcom.com>
To: Stanimir Varbanov <svarbanov@...e.de>
Cc: linux-pci@...r.kernel.org, Nicolas Saenz Julienne <nsaenz@...nel.org>, 
	Bjorn Helgaas <bhelgaas@...gle.com>, Lorenzo Pieralisi <lorenzo.pieralisi@....com>, 
	Cyril Brulebois <kibi@...ian.org>, bcm-kernel-feedback-list@...adcom.com, 
	jim2101024@...il.com, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof Wilczyński <kw@...ux.com>, 
	Rob Herring <robh@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@...ts.infradead.org>, 
	"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 10/12] PCI: brcmstb: Check return value of all
 reset_control_xxx calls

On Thu, Jul 4, 2024 at 9:49 AM Stanimir Varbanov <svarbanov@...e.de> wrote:

> Hi Jim,
>
> On 7/3/24 21:02, Jim Quinlan wrote:
> > In some cases the result of a reset_control_xxx() call have been ignored.
> > Now we check all return values of such functions and at the least issue a
> > dev_err(...) message if the return value is not zero.
> >
>
> When I made the comment for the return value of reset_control_xxx API I
> was thinking for propagating the error to upper PCI layer and not just
> print it.
>
> Printing the error is a step forward but I don't think it is enough.
> Please drop the patch from the series, we can fix that problem in the
> driver with follow up patches.
>

I'll return the value up the chain as you want as there is a list of things
anyway for v3.

Regards
Jim Quinlan
Broadcom STB

>
> ~Stan
>
> > Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>
> > ---
> >  drivers/pci/controller/pcie-brcmstb.c | 33 ++++++++++++++++++++-------
> >  1 file changed, 25 insertions(+), 8 deletions(-)
> >
>

Content of type "text/html" skipped

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4210 bytes)