linux-kernel - Re: [PATCH] USB: serial: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fba80871-645f-4d8d-8992-424812e51cef@quicinc.com>
Date: Fri, 5 Jul 2024 07:36:14 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Johan Hovold <johan@...nel.org>
CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] USB: serial: add missing MODULE_DESCRIPTION() macros

On 7/5/2024 4:35 AM, Johan Hovold wrote:
> On Tue, Jun 11, 2024 at 10:52:54AM -0700, Jeff Johnson wrote:
>> With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/ch341.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb_debug.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/mxuport.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/navman.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/qcaux.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/usb-serial-simple.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/usb/serial/symbolserial.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> 
> I amended the commit message with the (recent) commit that added this
> W=1 warning (and dropped C=1). I also tweaked three descriptions
> slightly. End result is here:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git/commit/?h=usb-next&id=9f4dc05107a6db3743e6b9ea4014cbdc3795682d
> 
> Thanks.
> 
> Johan
LGTM, thanks for the cleanup!

/jeff