linux-kernel - Re: [PATCH v1 1/3] dt-bindings: arm: qcom,coresight-static-replicator: Add property for source filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b7a9bcf-6660-47bc-adc7-4e9a26548f29@quicinc.com>
Date: Sat, 6 Jul 2024 13:22:26 +0800
From: Tao Zhang <quic_taozha@...cinc.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
CC: Jie Gan <quic_jiegan@...cinc.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Mike Leach <mike.leach@...aro.org>, <coresight@...ts.linaro.org>,
        "Alexander
 Shishkin" <alexander.shishkin@...ux.intel.com>,
        Yuanfang Zhang
	<quic_yuanfang@...cinc.com>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Tingwei Zhang
	<quic_tingweiz@...cinc.com>,
        <linux-arm-msm@...r.kernel.org>, Rob Herring
	<robh+dt@...nel.org>,
        Song Chai <quic_songchai@...cinc.com>,
        Jinlong Mao
	<quic_jinlmao@...cinc.com>, <devicetree@...r.kernel.org>,
        Mathieu Poirier
	<mathieu.poirier@...aro.org>
Subject: Re: [PATCH v1 1/3] dt-bindings: arm:
 qcom,coresight-static-replicator: Add property for source filtering


On 7/5/2024 11:23 PM, Tao Zhang wrote:
>
> On 7/5/2024 6:38 PM, Rob Herring (Arm) wrote:
>> On Fri, 05 Jul 2024 16:51:50 +0800, Tao Zhang wrote:
>>> Add a new property "filter_src" to label the source corresponding
>>> to the output connection for a static replicator. By combining
>>> a funnel and a static replicator in devicetree, a new device that
>>> supports multi-port input and multi-port output is implemented.
>>> In order to match the output port with the input port and
>>> successfully build the trace path, add this new property to
>>> indicate the data source corresponding to this output port.
>>>
>>> Signed-off-by: Tao Zhang <quic_taozha@...cinc.com>
>>> ---
>>>   .../arm/arm,coresight-static-replicator.yaml   | 18 
>>> +++++++++++++++++-
>>>   1 file changed, 17 insertions(+), 1 deletion(-)
>>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: 
>> ^port@[01]$: Missing additionalProperties/unevaluatedProperties 
>> constraint
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: 
>> endpoint: Missing additionalProperties/unevaluatedProperties constraint
>>
>> doc reference errors (make refcheckdocs):
>>
>> See 
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240705085152.9063-2-quic_taozha@quicinc.com
>>
>> The base for the series is generally the latest rc1. A different 
>> dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>
> Yes, I didn't see this errors in running 'make dt_binding_check', I 
> will re-run this check
>
> according to your suggestion.
>
>
> Best,
>
> Tao

After upgrading dtschema and installing 'yamllint', I saw the above 
errors in running

'dt_binding_check'. I will fix them and update in the next patch series.


Best,

Tao

>
>>
>> Please check and re-submit after running the above command yourself. 
>> Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your 
>> schema.
>>
> _______________________________________________
> CoreSight mailing list -- coresight@...ts.linaro.org
> To unsubscribe send an email to coresight-leave@...ts.linaro.org