linux-kernel - Re: [PATCH v2 2/2] scsi: usb: uas: Implement the new shutdown callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB02174EF48B5319A27F256AE4B8D82@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM>
Date: Sat, 6 Jul 2024 10:20:19 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "oneukum@...e.com" <oneukum@...e.com>, "stern@...land.harvard.edu"
	<stern@...land.harvard.edu>, Kerem Karabay <kekrby@...il.com>, Orlando
 Chamberlain <orlandoch.dev@...il.com>, Linux Kernel Mailing List
	<linux-kernel@...r.kernel.org>, "linux-usb@...r.kernel.org"
	<linux-usb@...r.kernel.org>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "usb-storage@...ts.one-eyed-alien.net"
	<usb-storage@...ts.one-eyed-alien.net>
Subject: Re: [PATCH v2 2/2] scsi: usb: uas: Implement the new shutdown
 callback



> On 6 Jul 2024, at 3:39 PM, gregkh@...uxfoundation.org wrote:
> 
> On Sat, Jul 06, 2024 at 10:01:38AM +0000, Aditya Garg wrote:
>> From: Kerem Karabay <kekrby@...il.com>
>> 
>> This patch implements the new shutdown callback method added to
>> usb_driver on the UAS driver.
> 
> Again, says what it does, but not why.
> 

A standard implementation of shutdown callback has been implemented
for USB drivers. Since the UAS driver implements a shutdown callback
this patch enables it to use the new standard implementation.

Now looks fine?

Is the body of the first patch fine?