linux-kernel - Re: [PATCH v2] staging: iio: frequency: ad9834: Validate frequency parameter value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240706124146.036f152a@jic23-huawei>
Date: Sat, 6 Jul 2024 12:41:46 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Aleksandr Mishin <amishin@...rgos.ru>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Datta Shubhrajyoti
 <shubhrajyoti@...com>, linux-iio@...r.kernel.org,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
 lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] staging: iio: frequency: ad9834: Validate frequency
 parameter value

On Wed, 3 Jul 2024 18:29:43 +0200
Dan Carpenter <dan.carpenter@...aro.org> wrote:

> On Wed, Jul 03, 2024 at 06:45:06PM +0300, Aleksandr Mishin wrote:
> > In ad9834_write_frequency() clk_get_rate() can return 0. In such case
> > ad9834_calc_freqreg() call will lead to division by zero. Checking
> > 'if (fout > (clk_freq / 2))' doesn't protect in case of 'fout' is 0.
> > ad9834_write_frequency() is called from ad9834_write(), where fout is
> > taken from text buffer, which can contain any value.
> > 
> > Modify parameters checking.
> > 
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > 
> > Fixes: 12b9d5bf76bf ("Staging: IIO: DDS: AD9833 / AD9834 driver")
> > Suggested-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> > ---
> > v1->v2: Check if clk_freq == 0 directly instead of fout == 0
> >  as suggested by Dan  
> 
> 
> Thanks!
> 
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
> 
Applied and marked for stable.

> regards,
> dan carpenter
>