linux-kernel - Re: [PATCH 6/8] clk: qcom: Add support for Display clock Controllers on SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d8e3779-aebf-4f27-bd54-58007b80192a@linaro.org>
Date: Sat, 6 Jul 2024 14:25:37 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Taniya Das <quic_tdas@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 quic_jkona@...cinc.com, quic_imrashai@...cinc.com
Subject: Re: [PATCH 6/8] clk: qcom: Add support for Display clock Controllers
 on SA8775P

On 5.07.2024 5:04 PM, Dmitry Baryshkov wrote:
> On Wed, Jul 03, 2024 at 11:17:01PM GMT, Taniya Das wrote:
>>
>>
>> On 6/21/2024 10:03 AM, Taniya Das wrote:
>>>> Please merge this into one to save on boilerplate, take a look
>>>> at dispcc-sc8280xp.c
>>>>
>>>
>>> I did take a look at the dispcc for SC8280XP before posting the series,
>>> but it kind of looked tricky to add fixes for a particular dispcc.
>>> Debugging could also be difficult in my opinion.
>>> Though I understand that we are trying to optimize by re-using few
>>> common structures/probe but from clocks side they are all redefined.
>>> That was the reason to keep them separate.
>>
>> Konrad, are you good with the proposal to keep the two instance of display
>> clock controllers as separate drivers? As I looking to post
>> the next patch series, please let me know your comments.
> 
> I'd say, continue with the separate drivers.

+1

Konrad