linux-kernel - Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d47b8c3-2f36-4325-b288-0faa40f876eb@web.de>
Date: Sat, 6 Jul 2024 14:56:21 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Guillaume Stols <gstols@...libre.com>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-fbdev@...r.kernel.org,
 Conor Dooley <conor+dt@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <michael.hennerich@...log.com>,
 Nuno Sá <nuno.sa@...log.com>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, David Lechner
 <dlechner@...libre.com>, Julien Stephan <jstephan@...libre.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH v3 8/8] iio: adc: ad7606: switch mutexes to scoped_guard

> Switching to scoped_guard simplifies the code and avoids to take care to
> unlock the mutex in case of premature return.

Can such a change description become more imperative?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n94

…
> +++ b/drivers/iio/adc/ad7606.c
…
> @@ -124,19 +122,19 @@ static irqreturn_t ad7606_trigger_handler(int irq, void *p)
…
>  	ret = ad7606_read_samples(st);
> -	if (ret == 0)
> -		iio_push_to_buffers_with_timestamp(indio_dev, st->data,
> -						   iio_get_time_ns(indio_dev));
> +	if (ret)
> +		goto error_ret;
>
> +	iio_push_to_buffers_with_timestamp(indio_dev, st->data,
> +					   iio_get_time_ns(indio_dev));
> +error_ret:
>  	iio_trigger_notify_done(indio_dev->trig);
…

I find that these control flow adjustments do not fit to the changelog.
They can be offered in another update step (on demand), can't they?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n81

There are no scoped_guard() calls performed in your patch.
How do you think about to use a summary phrase like “Switch mutex calls to mutex guard usage”?

Regards,
Markus