linux-kernel - Re: [PATCH v2 0/8] msm8937/msm8976/qcs404 icc patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bb295b8-a79f-48ea-800c-3176c2402021@gmail.com>
Date: Sat, 6 Jul 2024 15:41:30 +0200
From: Adam Skladowski <a39.skl@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
 Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Georgi Djakov <djakov@...nel.org>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/8] msm8937/msm8976/qcs404 icc patches


On 7/5/24 08:49, Krzysztof Kozlowski wrote:
> On 04/07/2024 22:02, Adam Skladowski wrote:
>> This series introduce new ICC drivers for some legacy socs
>> while at it also updates a bit of qcs404 driver which seems
>> to not receive much attention lately.
>> Please take in consideration i do not own any qcs404 board
>> so i cannot test anything else than if it compiles.
>>
>> Changes since v1
>> ================
>> 1. Reworded commit messages
>> 2. Adjusted yamls.
>> 3. Adjusted examples.
> Adjusted to what? This is supposed to be specific.
>
> BTW, you use here odd email address, so:
>
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> </form letter>
>
> Best regards,
> Krzysztof
>
Indeed i send patches from different OS with old kernel tree inside,
i haven't had idea about that.

Will update tree before sending.
Regarding v3 which im going to send anyway, should i reword changes in v2?

Like in v2 i Adjusted yaml to look the way msm8953 is(seems its wrong).

Adjusting examples refers to removing redundant nodes from yaml examples.

For sending i use this command:
git send-email --to-cover --cc-cover patch-dir/*.patch --cc
phone-devel@...r.kernel.org --cc ~postmarketos/upstreaming@...ts.sr.ht
--cc-cmd='scripts/get_maintainer.pl --norolestats patch-dir/*.patch'

Is switching to any different tool required?
I doubt i would be able to do it without making some big mistakes.