linux-kernel - Re: [PATCH] staging: ks7010: Remove unneeded check in ks_wlan_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bf57e119-d957-484b-be23-ea43811f30e3@gmail.com>
Date: Sat, 6 Jul 2024 16:23:55 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Aleksandr Mishin <amishin@...rgos.ru>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Dan Carpenter <dan.carpenter@...aro.org>,
 Zhang Shurong <zhang_shurong@...mail.com>, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] staging: ks7010: Remove unneeded check in
 ks_wlan_get_range()

On 7/6/24 16:16, Wolfram Sang wrote:
> On Fri, Jul 05, 2024 at 11:44:34PM +0300, Aleksandr Mishin wrote:
>> In ks_wlan_get_range() variable 'i' which value is always 12, is compared
>> to 2. This check is unneeded and should be removed.
>>
>> Remove unneeded check to clean up the code.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository")
>> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> 
> I thought this driver was to be removed[1]? Phillip (CCed), what is the
> current status? If you are busy, I can remove it as well...
> 
> [1] https://lore.kernel.org/all/igi27iwrzg3ovgj3sym4gsi45timpkt4vkl5ss5dbftdzat6p4@ctxcjocvunpt/
> 


Hi Wolfram,

no the driver is not removed yet. Planned to do this on the next cycle. 
I did remove two others and wanted to wait some time to see if any 
complains arise. I am a bit scared.

Please always consider: If you do not use the driver, it does not mean 
that anybody else is also not using it.

But may be you are right. I am a bit slow and to hesitant.

I plan to send deletion in 3 weeks.

Bye Philipp